refactor: parse with url to parse using xlsx file #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZolotarevAlexandr
approved these changes
Dec 2, 2025
Member
ZolotarevAlexandr
left a comment
ZolotarevAlexandr
left a comment
There was a problem hiding this comment.
Everything's fine, I marked couple of things that should be corrected (nothing too big), but overall everything works
src/cleaning/parse_cleaning_html.py
Outdated
|
|
||
| from src.logging_ import logger | ||
|
|
||
| # TODO: Rework to work with xlsx instead (better to def parse(dfs: dict[str, pd.DataFrame]) -> dict[str, list[date]])... |
Member
There was a problem hiding this comment.
You implemented it, so better to remove that todo
src/cleaning/parse_cleaning_html.py
Outdated
| days = df.iloc[2::2, :] | ||
| # drop first, second and days rows | ||
| df = df.drop(df.index[[0, 1, *range(2, len(df), 2)]]) | ||
| # flatten days |
Member
There was a problem hiding this comment.
Some comments are a bit excessive (like that one). But it's nice that there are comments in the first place
src/cleaning/parse_cleaning_html.py
Outdated
|
|
||
| # TODO: Rework to work with xlsx instead (better to def parse(dfs: dict[str, pd.DataFrame]) -> dict[str, list[date]])... | ||
|
|
||
| def process_dataframe(df, entries): |
Member
There was a problem hiding this comment.
We have type hints for function arguments and return values, add them for that one
src/cleaning/parser.py
Outdated
| """ | ||
|
|
||
| # TODO: Use parse_cleaning_html.py instead | ||
| logger.warning("Not implemented") |
src/cleaning/parser.py
Outdated
| # rdate=dates, | ||
| # ) | ||
| # ) | ||
| spreadsheet_id = "1xXnyinI1sNQ3ZKTPlKlqJKt4685oCz2R2LzlgEUztKs" |
Member
There was a problem hiding this comment.
Such things better to keep in config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes