Skip to content

AP-7781 # Fixed form store hidden columns not being saved as visible #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
divporter merged 3 commits into from
Mar 26, 2026
Merged

AP-7781 # Fixed form store hidden columns not being saved as visible #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1105054
AP-7781 # Fixed form store hidden columns not being saved as visible
mymattcarroll Mar 26, 2026
94c8db1
AP-7781 # Changelog entry
mymattcarroll Mar 26, 2026
218bb67
AP-7781 # Added better changelog entry (cursor)
mymattcarroll Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Lot / DP Numbers display for NSW Point V3 form element
- disabled on `Clickable` not disabling click function
- column visibility not persisting correctly after re-showing a hidden column in Data View

## [9.1.0] - 2026-02-23

Expand Down
4 changes: 3 additions & 1 deletion src/components/formStore/table/useFormStoreTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,9 @@ export default function useFormStoreTable({
const storageKey = localStorageKey(form.id)
const augmentedState = {
...state,
hiddenColumns: Object.keys(state.columnVisibility),
hiddenColumns: Object.entries(state.columnVisibility)
.filter(([, isVisible]) => !isVisible)
.map(([column]) => column),
Comment on lines +550 to +552
Copy link
Copy Markdown
Contributor

@divporter divporter Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't decide if I like it or not.

formId: table.options.meta?.formId,
}
localStorage.setItem(storageKey, JSON.stringify(augmentedState))
Expand Down
Loading