Skip to content

AP-7695 # Added taskCompletionTimestamp to uploadSubmission #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mymattcarroll merged 3 commits into from
Mar 31, 2026
Merged

AP-7695 # Added taskCompletionTimestamp to uploadSubmission #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dea4f5e
AP-7695 # Added taskCompletionTimestamp to uploadSubmission
mymattcarroll Mar 31, 2026
852d9c0
AP-7695 # Fixed changelog in previous release
mymattcarroll Mar 31, 2026
d43c415
Merge branch 'master' into AP-7695
mymattcarroll Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Added

- `taskCompletionTimestamp` to `OneBlinkUploader.uploadSubmission()` options
- `username` prop to `uploadPrefillData`

## [6.0.0] - 2026-03-31
Expand Down
121 changes: 70 additions & 51 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/OneBlinkUploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export default class OneBlinkUploader {
taskId,
taskActionId,
taskGroupInstanceId,
taskCompletionTimestamp,
formSubmissionDraftId,
completionTimestamp,
recaptchas = [],
Expand Down Expand Up @@ -127,6 +128,7 @@ export default class OneBlinkUploader {
taskId,
taskActionId,
taskGroupInstanceId,
taskCompletionTimestamp,
jobId,
previousFormSubmissionApprovalId,
recaptchas,
Expand Down
2 changes: 2 additions & 0 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ export type UploadFormSubmissionOptions = UploadOptions & {
* associated with
*/
taskGroupInstanceId?: string
/** The date and time (in ISO format) the task was completed */
taskCompletionTimestamp?: string
Copy link
Copy Markdown
Contributor

@divporter divporter Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we're saving it as savedAt but submitting as taskCompletionTimestamp

Copy link
Copy Markdown
Contributor

@divporter divporter Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I understand why, just putting out food for thought)

Copy link
Copy Markdown
Contributor Author

@mymattcarroll mymattcarroll Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we are actually saving it as createdAt. savedAt will be the database column that is not used for anything. These property names I have chosen seem consistent with existing property names from a client perspective. I am open to changing them though.

}

export type UploadAssetOptions = UploadOptions & {
Expand Down