refactor: moved duplicated function _process_reg_file to misc, remove… #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d unused inclcudes
the function _process_reg_file was duplicated in two different locations with exactly the same code. Moved everything to misc.py.
Only difference is some formatting stuff:
@@ -1,4 +1,3 @@ - def _process_reg_file(ubifs, inode, path, inodes): try: buf = bytearray() @@ -9,7 +8,6 @@ last_khash = start_key - 1 for data in sorted_data: - # If data nodes are missing in sequence, fill in blanks # with \x00 * UBIFS_BLOCK_SIZE if data.key['khash'] - last_khash != 1: @@ -35,6 +33,7 @@ d = d[:data.plaintext_size] buf += decompress(compr_type, data.size, d) + last_khash = data.key['khash'] verbose_log(_process_reg_file, 'ino num: %s, compression: %s, path: %s' % (inode['ino'].key['ino_num'], compr_type, path))