Fix UserInfo Gson deserialization and add ProGuard rules#23
Merged
Subterrane merged 4 commits intodevelopfrom Mar 17, 2026
Merged
Fix UserInfo Gson deserialization and add ProGuard rules#23Subterrane merged 4 commits intodevelopfrom
Subterrane merged 4 commits intodevelopfrom
Conversation
UserInfo fields with snake_case JSON keys (preferred_username, given_name, family_name, updated_at) were silently deserializing as null because Gson performs exact name matching against the camelCase Kotlin property names. Also changes updatedAt from String? to Long? to match the OIDC spec (updated_at is a Unix epoch timestamp), adds ProGuard consumer rules to prevent R8 from stripping Gson model fields, and adds deserialization tests. Supersedes #6, #13, #16. [no-ado]
This was referenced Mar 17, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@SerializedNameannotations toUserInfo.ktso Gson correctly maps snake_case JSON keys (preferred_username,given_name,family_name,updated_at) to camelCase Kotlin propertiesupdatedAttype fromString?toLong?to match the OIDC spec (Unix epoch timestamp)UserInfodeserialization (snake_case mapping and null handling)Longtype change forupdatedAtContext
This supersedes PRs #6, #13, and #16, which all independently identified and attempted to fix the same bug: OIDC UserInfo fields with snake_case names were always
nullafter deserialization. This PR combines the correct parts of each:@SerializedNameannotationsupdatedAttyped asInt?(overflows in 2038)@SerializedNameannotationsupdatedAtasString?; bundled unrelatedJSONConvertableinterface@SerializedName+Long?type + demo updatesSimpleDateFormatthread-safety issue in demoTest plan
UserInfoDeserializationTestpasses (snake_case field mapping + null handling)NetworkClientTeststill passesupdatedAttype change