Skip to content

Update UserInfo.kt #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alqueraf wants to merge 2 commits into from
Closed

Update UserInfo.kt #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8589beb
Update UserInfo.kt
Alqueraf Apr 19, 2021
fe41b78
Add missing import and annotation to all fields
Alqueraf Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion oneloginoidc/src/main/java/com/onelogin/oidc/userInfo/UserInfo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
package com.onelogin.oidc.userInfo

import com.google.gson.annotations.SerializedName

data class UserInfo(
@SerializedName("sub")
val sub: String,
@SerializedName("email")
Comment on lines +6 to +8
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @SerializedName annotations for 'sub' and 'email' are unnecessary since the JSON keys already match the Kotlin property names. Remove these redundant annotations to reduce clutter and follow the convention of only annotating fields where the names differ.

Suggested change
@SerializedName("sub")
val sub: String,
@SerializedName("email")
val sub: String,

Copilot uses AI. Check for mistakes.
val email: String,
@SerializedName("preferred_username")
val preferredUsername: String?,
@SerializedName("name")
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @SerializedName annotation for 'name' is unnecessary since the JSON key matches the Kotlin property name. Consider removing this redundant annotation.

Suggested change
@SerializedName("name")

Copilot uses AI. Check for mistakes.
val name: String?,
val updatedAt: String?,
@SerializedName("updated_at")
val updatedAt: Int?,
@SerializedName("given_name")
val givenName: String?,
@SerializedName("family_name")
val familyName: String?,
@SerializedName("groups")
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @SerializedName annotation for 'groups' is unnecessary since the JSON key matches the Kotlin property name. Consider removing this redundant annotation.

Suggested change
@SerializedName("groups")

Copilot uses AI. Check for mistakes.
val groups: List<String>?
)