View proposal with tiptap docs #484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin0h
force-pushed
the
tiptap-view-proposal-doc-ui
branch
from
7ab53fe to
98f1a19
Compare
valentin0h
force-pushed
the
tiptap-view-proposal-doc-ui
branch
from
98f1a19 to
815c7ea
Compare
valentin0h
force-pushed
the
tiptap-view-proposal-doc-ui
branch
from
bf35db9 to
da6af23
Compare
valentin0h
force-pushed
the
tiptap-view-proposal-doc-ui
branch
from
da6af23 to
b799719
Compare
valentin0h
force-pushed
the
tiptap-view-proposal-doc-ui
branch
from
b799719 to
0572e9f
Compare
valentin0h
commented
Jan 23, 2026
| existingProposal?.id, | ||
| existingProposal?.proposalData, | ||
| ]); | ||
| return `proposal-${instance.id}-${existingProposal?.id ?? crypto.randomUUID()}`; |
Collaborator
Author
There was a problem hiding this comment.
We shouldn't end up in this state, but if we handle it by creating a new doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #482. Renders proposal content from TipTap document server instead of legacy
descriptionfield.DocumentNotAvailableempty state when content fails to loadDemo
Success vs error state of document loading