Handle SSLError and ParsingError in error wrapping#11
Merged
Conversation
- Add rescue clauses for Faraday::SSLError and Faraday::ParsingError - Order SSLError before ConnectionFailed (SSLError is a subclass) - Update CLAUDE.md error hierarchy with ConnectionError, AuthenticationError, RateLimitError - Add tests for non-JSON body handling, SSL failures, and parsing errors
There was a problem hiding this comment.
Code Review
This pull request enhances the SDK's error handling by explicitly rescuing SSL and parsing errors within the HTTP client, updating the error hierarchy documentation, and adding comprehensive test coverage for these scenarios. The review feedback suggests improving the parsing error rescue by preserving the original exception cause and utilizing a more specific error class to maintain consistency with the rest of the library's error structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Faraday::SSLErrorandFaraday::ParsingErrorin HttpClientSSLErrorbeforeConnectionFailed(SSLError is a subclass)response_body: nil)Test plan
ConnectionErrorwith descriptive messageErrorwith underlying causeHttpRequestErrorwith nil body