INT-551: Adding 2 new endpoints for listing tasks & update readme #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YokySantiago
suggested changes
May 12, 2022
Contributor
YokySantiago
left a comment
YokySantiago
left a comment
There was a problem hiding this comment.
Great job here, I have some comments, though.
| 'autoDispatch' => ['method' => 'POST', 'path' => '/teams/:teamId/dispatch'], | ||
| 'getWorkerEta' => ['method' => 'GET', 'path' => '/teams/:teamId/estimate', 'queryParams' => true] | ||
| 'getWorkerEta' => ['method' => 'GET', 'path' => '/teams/:teamId/estimate', 'queryParams' => true], | ||
| 'listUnassignedTasks' => ['method' => 'GET', 'path' => '/teams/:teamId/tasks', 'queryParams' => true] |
Contributor
There was a problem hiding this comment.
We had named this method getTasks in the python wrapper so, we should keep the same names across the wrappers, shouldn't we?
| 'setSchedule' => ['method' => 'POST', 'path' => '/workers/:workerId/schedule'], | ||
| 'matchMetadata' => ['method' => 'POST', 'path' => '/workers/metadata'] | ||
| 'matchMetadata' => ['method' => 'POST', 'path' => '/workers/metadata'], | ||
| 'listAssignedTasks' => ['method' => 'GET', 'path' => '/workers/:workerId/tasks', 'queryParams' => true] |
Contributor
There was a problem hiding this comment.
We had named this method getTasks in the python wrapper so, we should keep the same names across the wrappers, shouldn't we?
| "warnings" => [] | ||
| ] | ||
| ], | ||
| "listUnassignedTasks" => [ |
Contributor
There was a problem hiding this comment.
We also need to create the test case in the tests/OnfleetTest.php file
| "skipSMSNotifications" => false, | ||
| "metadata" => [] | ||
| ], | ||
| "listAssignedTasks" => [ |
Contributor
There was a problem hiding this comment.
We also need to create the test case in the tests/OnfleetTest.php file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what's new:
listAssignedTasksendpoint forworkerslistUnassignedTasksendpoint forteams