Skip to content

Comments

Add Fix128 and UFix128 types to Cadence#4131

Merged
SupunS merged 67 commits intomasterfrom
supun/fix128-interpreter
Sep 3, 2025
Merged

Add Fix128 and UFix128 types to Cadence#4131
SupunS merged 67 commits intomasterfrom
supun/fix128-interpreter

Conversation

@SupunS
Copy link
Member

@SupunS SupunS commented Aug 6, 2025

Working towards #484

Description

Implements the FLIP: onflow/flips#342


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Aug 6, 2025
@SupunS SupunS added the Feature label Aug 6, 2025
@SupunS SupunS force-pushed the supun/fix128-interpreter branch from a34605b to 363985e Compare August 8, 2025 15:55
@SupunS SupunS changed the title Add Fix128 type to Cadence Add Fix128 and UFix128 types to Cadence Aug 21, 2025
[Compiler] Support `Fix128` and `UFix128` types in compiler
@SupunS SupunS changed the base branch from feature/fix128 to master August 22, 2025 20:19
@SupunS SupunS force-pushed the supun/fix128-interpreter branch from 7fb1e30 to 473d757 Compare August 22, 2025 21:23
@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f69e3d8
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member

@SupunS Now that the FLIP has been merged, is this PR ready to get merged? Is there anything left to be done other than resolving the conflict?

@SupunS
Copy link
Member Author

SupunS commented Sep 2, 2025

I'm cleaning up a few things (mostly errors) in onflow/fixed-point. Once that's done, need to tag a release there, and then can update this branch (will open a PR on to of this). After that this PR should be ready to get merged.

@SupunS SupunS mentioned this pull request Sep 2, 2025
6 tasks
@SupunS
Copy link
Member Author

SupunS commented Sep 3, 2025

This PR is now ready to be merged!

All changes in this PR were added from the below smaller PRs, and they have been reviewed already individually.

So reviewing this PR entirely is not really necessary, but one final look is much appreciated 🙏

@SupunS SupunS merged commit 51c15e7 into master Sep 3, 2025
11 of 12 checks passed
@SupunS SupunS deleted the supun/fix128-interpreter branch September 3, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants