Skip to content

Comments

Add setup to sell item and use generic types#111

Merged
joshuahannan merged 4 commits intomainfrom
josh/small-enhancements
Aug 4, 2025
Merged

Add setup to sell item and use generic types#111
joshuahannan merged 4 commits intomainfrom
josh/small-enhancements

Conversation

@joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Jul 24, 2025

Closes #104
Closes #95

  • Adds setup storefront logic to sell item transactions so that they don't have to run a separate setup transaction
  • Use generic token types in the V2 transactions so developers don't have to replace with their own specific types
  • Update some import placeholders

Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made a couple minor suggestions for consistent camel case - there are a couple places where pascal case is used.

@joshuahannan joshuahannan merged commit d70cf3f into main Aug 4, 2025
2 checks passed
@joshuahannan joshuahannan deleted the josh/small-enhancements branch August 4, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add storefront configuration to the sell item transaction Use general token interface types and V2 standards features in storefront transactions

2 participants