Skip to content

Conversation

jarugupj
Copy link
Contributor

@jarugupj jarugupj commented Sep 30, 2025

TL;DR

Adds a deploy github subcommand to deploy applications directly from a GitHub URL, simplifying the deployment workflow.

Why we made these changes

This change allows users to deploy directly from a GitHub repository without needing a local copy of the code. This makes it faster and more convenient to deploy projects, especially in CI/CD environments or for quick tests.

What changed?

  • cmd/deploy.go: Introduced the deploy github subcommand with flags for repository URL, Git ref, and entrypoint. This new command constructs a multipart HTTP request to the /deployments endpoint and streams deployment events back to the user.
  • go.mod: Updated dependencies to support the new deployment functionality.

Validation

  • Verified that deploy github successfully deploys a public GitHub repository.
  • Tested with private repositories to ensure authentication with a GitHub token works correctly.
  • Confirmed that invalid GitHub URLs are handled with clear error messages.

Description generated by Mesa. Update settings

@jarugupj jarugupj marked this pull request as ready for review September 30, 2025 23:16
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of dd88c41...64bc4d7

Analysis

  1. Architectural Inconsistency: The new GitHub deployment functionality creates a parallel implementation path that bypasses the established kernel SDK pattern, resulting in fragmented architecture that will require separate maintenance.

  2. Unnecessary Code Duplication: The implementation reimplements HTTP client logic, multipart form handling, and response processing instead of leveraging existing functionality in the kernel SDK, increasing maintenance burden and bug potential.

  3. Poor Configuration Management: Hardcoded values (region 'aws.us-east-1a') and inconsistent base URL handling deviate from the configuration approach used in other commands.

  4. Inadequate Error Handling: Multiple ignored error values throughout the new function could cause silent failures and debugging challenges.

  5. Recommendation: Extend the kernel SDK to natively support GitHub source deployments rather than creating a parallel implementation.

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

2 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant