-
Notifications
You must be signed in to change notification settings - Fork 3
move docs links from .docs to docs/ #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed full review of 2c1b6ae...a3c7f13
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review
- Request a full code review/review latest
- Review only changes since the last review/describe
- Generate PR description. This will update the PR body or issue comment depending on your configuration/help
- Get help with Mesa commands and configuration options
14 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
templates/python/sample-app/main.py
Outdated
Example app that instantiates a persisted Kernel browser that can be reused across invocations | ||
Invoke this action to test Kernel browsers manually with our browser live view | ||
https://docs.onkernel.com/launch/browser-persistence | ||
https://onkernel.com/docs/launch/browser-persistence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be /docs/browsers/persistence
import { Stagehand } from "@browserbasehq/stagehand"; | ||
import { Kernel, type KernelContext } from '@onkernel/sdk'; | ||
import { Stagehand } from '@browserbasehq/stagehand'; | ||
import { Kernel, KernelContext } from '@onkernel/sdk'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ensure we don't change anything else here besides the docs link, I think your formatting got applied here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Apologies, settings from previous company were ported over to Cursor. Reverting all import sorting!
a3c7f13
to
6702811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last one!
@@ -1,6 +1,5 @@ | |||
import { Kernel, type KernelContext } from '@onkernel/sdk'; | |||
import { samplingLoop } from './loop'; | |||
import { chromium } from 'playwright'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep this in here
updated docs links to go with our new (S/G)EO-friendly structure
TL;DR
Moved documentation from the hidden
.docs
directory todocs/
and updated all internal links to improve discoverability.Why we made these changes
To improve our documentation's SEO by moving it from a hidden directory to a public, crawlable
docs/
directory, making it more accessible to search engines and users.What changed?
.docs
directory todocs/
.README.md
files and code comments across Python and TypeScript templates to use the newonkernel.com/docs
path.Description generated by Mesa. Update settings