-
Notifications
You must be signed in to change notification settings - Fork 4
Limit frontend to rewards with migration notice #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit frontend to rewards with migration notice #1116
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe updates remove navigation elements, headers, and banners from the SaaS layout and dashboard, consolidating messaging into a new migration banner. The root and dashboard routes are redirected to the rewards page. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Layout
participant AppMigrationBanner
User->>Layout: Access SaaS app or dashboard
Layout->>AppMigrationBanner: Render migration banner
AppMigrationBanner->>User: Display migration alert and link
Layout->>User: Render children content below banner
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm warn config production Use ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/(saas)/my-dashboard/layout.tsx (1)
19-19: Consider removing unused hook or utilizing its return value.The
useMyRewardsTransactionsSidepanelhook is called but its return value (likely containing anopenfunction) is not used. Since the "See Transactions" button was removed, this hook call may no longer be necessary.- useMyRewardsTransactionsSidepanel();Alternatively, if the hook is needed for side effects or will be used later, consider adding a comment explaining why it's called without using the return value.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/(saas)/layout.tsx(1 hunks)app/(saas)/my-dashboard/layout.tsx(1 hunks)next.config.mjs(2 hunks)shared/features/app-migration-banner/app-migration-banner.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
app/(saas)/layout.tsx (3)
app/(saas)/saas-providers.tsx (1)
SaasProviders(7-15)shared/ui/sidebar.tsx (1)
SidebarInset(630-630)shared/features/app-migration-banner/app-migration-banner.tsx (1)
AppMigrationBanner(4-22)
app/(saas)/my-dashboard/layout.tsx (3)
shared/panels/my-rewards-transactions-sidepanel/my-rewards-transactions-sidepanel.hooks.ts (1)
useMyRewardsTransactionsSidepanel(3-5)shared/features/page-content/page-content.tsx (1)
PageContent(8-23)app/(saas)/my-dashboard/_features/request-payment/request-payment.tsx (1)
RequestPayment(13-63)
🔇 Additional comments (7)
shared/features/app-migration-banner/app-migration-banner.tsx (1)
1-22: Well-implemented migration banner component.The component follows React best practices with clean structure and clear messaging. The use of design system components (
Alert,BaseLink) ensures consistency with the rest of the application.next.config.mjs (2)
10-12: Root redirect correctly updated to align with migration strategy.The redirect from
/to/my-dashboard/rewardsproperly supports the new focus on rewards functionality during the migration period.
34-36: Dashboard redirect correctly updated to focus on rewards.The redirect from
/my-dashboardto/my-dashboard/rewardsaligns perfectly with the removal of dashboard navigation tabs and the focus on rewards functionality during migration.app/(saas)/layout.tsx (2)
10-10: Proper import for the new migration banner component.The import statement correctly references the new
AppMigrationBannercomponent that will replace the complex navigation elements.
15-21: Layout effectively simplified for migration period.The removal of
AppSidebar,AppHeader, and multiple banner components in favor of a singleAppMigrationBannercreates a clean, focused experience that aligns with the migration strategy. TheSidebarInsetwrapper is retained for consistent spacing.app/(saas)/my-dashboard/layout.tsx (2)
3-16: Import cleanup effectively supports layout simplification.The removal of tab navigation, button, and routing-related imports aligns well with the simplified dashboard layout that focuses solely on the rewards functionality.
23-29: Dashboard header effectively simplified for migration period.The replacement of complex tab navigation with a simple container holding only the
RequestPaymentcomponent creates a focused user experience that aligns perfectly with the migration strategy and the new redirect configuration.
Summary
/and/my-dashboardto rewards pageTesting
npm run lint(fails:nextnot found)npm test(fails:vitestnot found)Summary by CodeRabbit