Skip to content

Extend preset tours to recorded tours.#735

Open
HansBusch wants to merge 7 commits intodevelopmentfrom
video/record-tours
Open

Extend preset tours to recorded tours.#735
HansBusch wants to merge 7 commits intodevelopmentfrom
video/record-tours

Conversation

@HansBusch
Copy link
Copy Markdown
Member

Alternative proposal to supporting recording tours.

doc/PTZ.xml Outdated
@@ -1734,7 +1727,8 @@ Add GeoMove</revremark>
</section>
<section>
<title>Preset Tour Operations</title>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section now be named Tour Operations?

- Rename new ExtendedPTZPresetOperations to PTZTourOperations.
- Make operation extensible.
doc/PTZ.xml Outdated
@@ -1941,7 +1946,10 @@ Add GeoMove</revremark>
<para>Stop: indicates stopping the preset tour.</para>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>Stop: indicates stopping the preset tour.</para>
<para>Stop: indicates stopping the preset tour or the recording.</para>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the device can have a limitation on the number of recorded tours, we should have a capability. This allows a better user experience for the client by preventing the action instead of handling an error when we start the recording.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a fault if maximum number of recordings is reached.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @cemond-genetec

- Add separate PTZ node information about supported number of recorded tours.
- Streamline requirements.
…ypes.

Revert extension of tour-operations as now original set is sufficient.
doc/PTZ.xml Outdated
@@ -1806,14 +1814,16 @@ Add GeoMove</revremark>
<varlistentry>
<term>access class</term>
<listitem>
<para role="access">READ_MEDIA</para>
<para role="access">READ_MEDIA </para>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert space

Suggested change
<para role="access">READ_MEDIA </para>
<para role="access">READ_MEDIA</para>

@@ -1806,14 +1814,16 @@ Add GeoMove</revremark>
<varlistentry>
<term>access class</term>
<listitem>
<para role="access">READ_MEDIA</para>
<para role="access">READ_MEDIA </para>
</listitem>
</varlistentry>
</variablelist>
</section>
<section>
<title>GetPresetTourOptions</title>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GetRecordedTourOptions for AutoStart and recurring time ?

doc/PTZ.xml Outdated
</listitem>
<listitem>
<para>Pause:iIndicates pausing the preset tour.</para>
<para>Record: start an new recording and override any existing recording.</para>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record operation is no longer needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cemond-genetec better to keep for backword compatability.

Copy link
Copy Markdown
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments :)

doc/PTZ.xml Outdated
@@ -420,6 +412,10 @@ Add GeoMove</revremark>
<listitem>
<para>MaximumNumberOfPresetTours – Indicates number of preset tours that can be created. Required preset tour operations shall be available for this PTZ node if one or more preset tours are supported.</para>
</listitem>
<listitem>
<para>MaxRecordedTours - Indicatesthe maximum number of recorded tours that can be
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>MaxRecordedTours - Indicatesthe maximum number of recorded tours that can be
<para>MaxRecordedTours - Indicates the maximum number of recorded tours that can be

doc/PTZ.xml Outdated
@@ -1885,9 +1897,54 @@ Add GeoMove</revremark>
</varlistentry>
</variablelist>
</section>
<section>
<title>RecordTour</title>
<para>Create an recorded tour or overwrite an existing tour. Finish the recording with tour
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>Create an recorded tour or overwrite an existing tour. Finish the recording with tour
<para>Create a recorded tour or overwrite an existing tour. Finish the recording with tour

doc/PTZ.xml Outdated
</listitem>
<listitem>
<para>Pause:iIndicates pausing the preset tour.</para>
<para>Record: start an new recording and override any existing recording.</para>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cemond-genetec better to keep for backword compatability.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @cemond-genetec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants