Skip to content

let users specify resourcing caps #3403

Merged
pablonyx merged 8 commits intomainfrom
resource_limits
Dec 12, 2024
Merged

let users specify resourcing caps #3403
pablonyx merged 8 commits intomainfrom
resource_limits

Conversation

@pablonyx
Copy link
Copy Markdown
Contributor

@pablonyx pablonyx commented Dec 10, 2024

Description

Fixes https://linear.app/danswer/issue/DAN-1147/add-option-for-resource-limits-in-compose-file-to-prevent-danswer-from

How Has This Been Tested?

  • Set no configuration
  • Set configuration + modify with environment variables + check resulting limits in Docker container each time

Accepted Risk (provide if relevant)

  • Poor defaults

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:31pm

@pablonyx pablonyx changed the title let users specify resourcing caps (wip) let users specify resourcing caps Dec 10, 2024
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@pablonyx pablonyx added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 9cacb37 Dec 12, 2024
@Weves Weves deleted the resource_limits branch April 5, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants