Open
Conversation
Loading with Bobs & Angles caused a crash on a nil at this point.
The previous implementation had several issues: * The slowest belt detection was broken * It always created a prerequisite on the upgrade of the external connections to the previous tier of belt, even if this was the slowest belt tier. This change reworks the creation by creating an ordering of the belts by speed. The first entry is the slowest and thus does not need an upgrade, the sencond one does not need a prerequisite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combination of hardening the walk over technologies and fixing the backup case to be more robust against adding slower belts.
I've tested the backup generation by loading a bobs + angles while manually disabling the technology detection. The latter was done by adding a
and falsein one of the if statements.