Open
Conversation
billsegall
added a commit
to billsegall/aeron-go
that referenced
this pull request
Dec 15, 2021
go-logging is unmaintained since 2016 and has significant reentrancy problems causing crashes. See for example: op/go-logging#75 op/go-logging#102 op/go-logging#105 To fix this we introduce a wrapper for a subset of the go-logging library mapped on to Uber's zap logging library and switch to using that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As comments in #75 , this pr just fix backend data race.the benchmark is better than lock's solution.