Skip to content

Conversation

@errt
Copy link
Collaborator

@errt errt commented Jul 5, 2023

We have an analysis that identifies Strings set as system properties, use it for, e.g., reflection analysis.

This is WIP, as dependency handling and type changes (Set[String] instead of String) still have to be done. I won't continue on this for now.

@johannesduesing I assigned you to this, as it is part of the greater task of more proper string analysis that also includes PR #1

@johannesduesing
Copy link
Collaborator

johannesduesing commented Nov 14, 2023

/it:test

EDIT: This comment was used to test whether the changes introduced in #155 actually work as intended - which they seem to do, the job status is set to pending as expected.

@maximilianruesch
Copy link
Collaborator

Note: Work on the string analysis from PR #1 includes work on the system properties analysis. Thus, if #1 is merged, we can close this PR.

@johannesduesing johannesduesing removed their assignment Sep 11, 2024
@errt
Copy link
Collaborator Author

errt commented Jun 12, 2025

I don't think that is true. #1 works on the analysis of SystemProperties, but does not use the results for reflection analysis, which is what this PR is about. Instead #214 integrates StringAnalysis results with the reflection analysis. However, I'm not sure whether #214 would also result in the use of results from SystemProperties (I think it does) and also it only seems to use StringAnalysis results for Class.forName, not in other places that reflection analysis relies on Strings.
The work started here should probably continue in #214, but I will leave this PR open for now to remind us that #214 might need further extension.

@errt
Copy link
Collaborator Author

errt commented Aug 29, 2025

I have updated #214 to use the string analysis for all strings used in reflection, rendering this PR obsolete.

@errt errt closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants