Add conditional library type for RARE based on Oasis target#2
Closed
matthew-mccall wants to merge 1 commit intomainfrom
Closed
Add conditional library type for RARE based on Oasis target#2matthew-mccall wants to merge 1 commit intomainfrom
matthew-mccall wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Superseded by #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic in the
src/CMakeLists.txtbuild configuration to make the type of theRARElibrary match the type of the existingOasis::Oasistarget when building on Windows. This ensures consistency in how libraries are built and linked, particularly for Windows environments.Build system improvements:
src/CMakeLists.txtfile to check if the build is on Windows and if theOasis::Oasistarget exists, then sets theRARElibrary to be eitherSHAREDorSTATICto match the type ofOasis::Oasis. If the type is unknown, it defaults to the standard behavior.