chore: upgrade linters to v2, use os.OpenRoot for safe file access#32
Merged
bojanrajkovic merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
… for safe file access Upgrade golangci-lint from 1.64.5 to 2.9.0 (major version) and gofumpt from 0.7.0 to 0.9.2. Migrate .golangci.yml to v2 config format and fix all new lint issues. Replace all os.ReadFile calls with os.OpenRoot + fs.FS to eliminate gosec G304 warnings through defense-in-depth rather than nolint directives. Core logic now accepts fs.FS, enabling in-memory testing with fstest.MapFS. Path-based public APIs remain as thin wrappers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Test Plan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.ymlto v2 config format (formatters section,linters.exclusions.rules,gosimplemerged intostaticcheck)os.ReadFilecalls withos.OpenRoot+fs.FSto eliminate gosec G304 warnings through defense-in-depth rather than nolint directivesfs.FS-based public APIs (ReadPluginManifestFS,ScanPluginComponentsFS,ReadPluginConfigsFS) for testability and shared-root usagefstest.MapFSfor in-memory filesystem testing🤖 Generated with Claude Code