feat(config): align init/config UX with atlassian-cli patterns#44
feat(config): align init/config UX with atlassian-cli patterns#44
Conversation
- Refactor init command to use huh forms with validation - Pre-populate form fields from existing config values - Add --force flag and confirmation prompt to config clear - Remove config set command (use init for config changes) - Fix token masking to use 8 asterisks: first4********last4 - Add tests for maskToken function Closes #43
Test Coverage AssessmentSummaryThe PR adds a test file ( What's Well Tested
This is solid coverage with good boundary testing. Coverage Gaps1.
The confirmation flow has branching logic that could benefit from unit tests, particularly the string parsing ( 2.
The 3.
4. Removed
VerdictAcceptable coverage for this PR. The key business logic change (
The test plan in the PR description appropriately lists manual verification for the interactive elements. A reviewer should verify those manual checks are completed before merging. Recommendations (optional, non-blocking)If the team wants to increase coverage in the future:
|
Summary
Aligns hspt init and config commands with UX patterns established in atlassian-cli.
Changes
--forceflag; shows confirmation prompt when not providedinitto change configurationfirst4...last4tofirst4********last4Test plan
make buildpassesmake testpassesmake lintpasseshspt initshows styled formhspt config showmasks token correctlyhspt config clearprompts for confirmationCloses #43