Merged
Conversation
Add `nrq keys` commands (list, get, create, update, delete) as ergonomic wrappers around the NerdGraph apiAccess API. Closes #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
During annual key rotations, managing API keys requires hand-crafting NerdGraph GraphQL mutations which is error-prone and hard to remember. First-class CLI commands make key operations ergonomic and scriptable.
Summary
nrq keys list— search keys with optional--typeand--accountfiltersnrq keys get <id>— inspect a specific key (auto-detects type if--typeomitted)nrq keys create --type user|ingest --name <name>— create user or ingest keysnrq keys update <id>— update key name/notes (auto-detects type if--typeomitted)nrq keys delete <id>...— delete one or more keys with confirmation promptapi/keys.gowrapping NerdGraphapiAccessqueries and mutationsTest plan
make verifypasses (fmt, lint, tests)nrq keys create --type user --name "test-key", thenlist,get,update --name,deleteCloses #82