Skip to content

🌱 bump open-cluster-management/api to v1.3.0#380

Merged
openshift-merge-bot[bot] merged 1 commit intoopen-cluster-management-io:mainfrom
qiujian16:bump-1.3
Apr 29, 2026
Merged

🌱 bump open-cluster-management/api to v1.3.0#380
openshift-merge-bot[bot] merged 1 commit intoopen-cluster-management-io:mainfrom
qiujian16:bump-1.3

Conversation

@qiujian16
Copy link
Copy Markdown
Member

@qiujian16 qiujian16 commented Apr 29, 2026

Summary

Related issue(s)

Fixes #

Summary by CodeRabbit

  • Chores
    • Updated cluster management and API dependencies to stable release versions for improved compatibility and reliability.
    • Advanced observability framework versions for enhanced system monitoring capabilities.
    • Upgraded system libraries to latest patches for stability improvements.

Signed-off-by: Jian Qiu <gothicqiujian@gmail.com>
@openshift-ci openshift-ci Bot requested review from elgnay and zhujian7 April 29, 2026 15:57
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Walkthrough

Updated open-cluster-management.io/api and sdk-go pseudo-versions to v1.3.0 release, advanced OpenTelemetry modules to v1.43.0, and bumped golang.org/x/sys to v0.42.0. All changes are version updates in require blocks with no logic modifications.

Changes

Cohort / File(s) Summary
Primary Dependency Upgrades
go.mod
Upgraded open-cluster-management.io/api and sdk-go from pseudo-versions to v1.3.0 release; advanced OpenTelemetry modules (go.opentelemetry.io/otel*) from v1.42.0 to v1.43.0; bumped golang.org/x/sys from v0.41.0 to v0.42.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • zhiweiyin318
  • elgnay
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete—it only contains the repository template with no actual summary, related issues, or substantive content filled in. Provide a detailed summary of the dependency upgrade, list any breaking changes, and document migration notes or testing performed for the v1.3.0 release.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: bumping open-cluster-management/api to v1.3.0. It uses the appropriate emoji and is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@qiujian16
Copy link
Copy Markdown
Member Author

/assign @mikeshng

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (3)
go.mod (3)

25-26: OCMP API/sdk-go v1.3.0 bump: validate compile + client/informer compatibility.

These are direct dependency bumps to open-cluster-management.io/api v1.3.0 and open-cluster-management.io/sdk-go v1.3.0. Given this repo instantiates versioned clientsets/informers (e.g., NewForConfig() usage and client interfaces for addon/cluster/work), you should confirm:

  • the generated clientsets/informers you use still compile unchanged,
  • any API surface changes (types/fields/methods) didn’t break consumers,
  • integration tests still pass.

Please run go test ./... (and ideally the integration test suite used in CI) after updating the lockfile/go.sum to confirm no hidden breakage from the API client bump.

Also consider running a quick go mod tidy in the branch to ensure the dependency graph is consistent after the bump.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 25 - 26, You bumped open-cluster-management.io/api and
sdk-go to v1.3.0 but must verify compatibility: run go mod tidy and update
go.sum, then run go test ./... and any CI integration tests to catch compile or
runtime breaks; specifically confirm that generated clientsets/informers (places
that call NewForConfig() and references to the client interfaces for
addon/cluster/work) still compile and that any changed API types/fields/methods
used by your code are updated (regenerate clients/informers if needed), and if
tests or compile fail, adjust callers to the new API surface or regenerate the
generated code and commit the updated artifacts.

111-116: OpenTelemetry module alignment: verify exporter compatibility with core SDK.

You bumped go.opentelemetry.io/otel, /metric, /sdk, and /trace all to v1.43.0, which is good. However, this file still pins OTLP trace exporters (go.opentelemetry.io/otel/exporters/otlp/...) at v1.34.0.

Please verify that this cross-version combination is intentional and works:

  • build compiles,
  • telemetry initialization doesn’t error at runtime,
  • trace/metric pipelines behave as expected in tests.

Run your standard unit + integration tests that exercise telemetry (or at minimum, go test ./...) and confirm no OpenTelemetry runtime warnings/errors are emitted.

If issues appear, the typical fix is to align all go.opentelemetry.io/otel/* modules to the same version via go mod tidy (or explicitly bump exporters to match).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 111 - 116, The OTLP exporter modules
(go.opentelemetry.io/otel/exporters/otlp/otlptrace and otlptracegrpc at v1.34.0)
are out of sync with the core otel modules bumped to v1.43.0; run your
verification by executing go test ./... and your telemetry integration tests,
check for build/runtime OpenTelemetry warnings/errors, and if any appear align
versions by updating the exporter modules to v1.43.0 (or run go mod tidy to
reconcile), then re-run tests to confirm telemetry initialization and pipelines
(otel/sdk, otel/trace, otel/metric and the otlp exporters) are all working
without errors.

127-127: golang.org/x/sys v0.42.0: run vuln scan + cross-platform build check.

golang.org/x/sys is bumped to v0.42.0 (indirect). This usually won’t require code changes, but it can introduce security fixes or behavior changes relevant to syscall/platform support.

Please run a vulnerability scan (e.g., govulncheck) and ensure CI covers all target OS/arch combinations your project supports.

If you don’t already do it, add/ensure a CI job step that runs govulncheck for PR dependency updates.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 127, The dependency bump to golang.org/x/sys v0.42.0 needs a
vuln scan and cross-platform build verification: run govulncheck locally against
the module and fix/patch any reported issues; add or update CI to run
govulncheck as a step (e.g., a job named "govulncheck" or similar) and add a
build matrix that runs go build/go test for all supported GOOS/GOARCH
combinations your project supports to catch platform-specific syscall changes;
ensure the CI step fails the job on any vuln findings or build/test failures and
include the govulncheck invocation and matrix configuration in your workflow
file so future dependency bumps are automatically checked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@go.mod`:
- Around line 25-26: You bumped open-cluster-management.io/api and sdk-go to
v1.3.0 but must verify compatibility: run go mod tidy and update go.sum, then
run go test ./... and any CI integration tests to catch compile or runtime
breaks; specifically confirm that generated clientsets/informers (places that
call NewForConfig() and references to the client interfaces for
addon/cluster/work) still compile and that any changed API types/fields/methods
used by your code are updated (regenerate clients/informers if needed), and if
tests or compile fail, adjust callers to the new API surface or regenerate the
generated code and commit the updated artifacts.
- Around line 111-116: The OTLP exporter modules
(go.opentelemetry.io/otel/exporters/otlp/otlptrace and otlptracegrpc at v1.34.0)
are out of sync with the core otel modules bumped to v1.43.0; run your
verification by executing go test ./... and your telemetry integration tests,
check for build/runtime OpenTelemetry warnings/errors, and if any appear align
versions by updating the exporter modules to v1.43.0 (or run go mod tidy to
reconcile), then re-run tests to confirm telemetry initialization and pipelines
(otel/sdk, otel/trace, otel/metric and the otlp exporters) are all working
without errors.
- Line 127: The dependency bump to golang.org/x/sys v0.42.0 needs a vuln scan
and cross-platform build verification: run govulncheck locally against the
module and fix/patch any reported issues; add or update CI to run govulncheck as
a step (e.g., a job named "govulncheck" or similar) and add a build matrix that
runs go build/go test for all supported GOOS/GOARCH combinations your project
supports to catch platform-specific syscall changes; ensure the CI step fails
the job on any vuln findings or build/test failures and include the govulncheck
invocation and matrix configuration in your workflow file so future dependency
bumps are automatically checked.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 02931e66-195d-43b0-8c12-7ce2468896c3

📥 Commits

Reviewing files that changed from the base of the PR and between f4bc737 and 9083889.

⛔ Files ignored due to path filters (67)
  • go.sum is excluded by !**/*.sum
  • vendor/go.opentelemetry.io/otel/.golangci.yml is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/CHANGELOG.md is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/Makefile is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/RELEASING.md is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/encoder.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/hash.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/internal/attribute.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/kv.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/type_string.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/value.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/dependencies.Dockerfile is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/internal/x/features.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/resource/config.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/resource/host_id.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/resource/resource.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/trace/provider.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/trace/sampling.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/sdk/version.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/trace/trace.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/version.go is excluded by !vendor/**
  • vendor/go.opentelemetry.io/otel/versions.yaml is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/asm_darwin_arm64_gc.s is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_darwin_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_darwin_arm64_other.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_gccgo_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_other_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/cpu/syscall_darwin_arm64_gc.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/plan9/syscall_plan9.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/windows/aliases.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/windows/registry/key.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/windows/syscall_windows.go is excluded by !vendor/**
  • vendor/modules.txt is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1alpha1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1beta1/conversion.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1beta1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1beta1/types_managedclusteraddon.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/addon/v1beta1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1alpha1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/0000_02_clusters.open-cluster-management.io_placements.crd.yaml is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/0000_03_clusters.open-cluster-management.io_placementdecisions.crd.yaml is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/types_placement.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/types_placementdecision.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta2/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/cluster/v1beta2/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/operator/v1/0000_01_operator.open-cluster-management.io_clustermanagers.crd.yaml is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/operator/v1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/operator/v1/types_clustermanager.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/operator/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/operator/v1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/work/v1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/work/v1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/work/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/api/work/v1alpha1/zz_generated.model_name.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/sdk-go/pkg/tls/config.go is excluded by !vendor/**
  • vendor/open-cluster-management.io/sdk-go/pkg/tls/configmap.go is excluded by !vendor/**
📒 Files selected for processing (1)
  • go.mod

Copy link
Copy Markdown
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Thank you!

@openshift-ci openshift-ci Bot added the lgtm label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit bbaaa1e into open-cluster-management-io:main Apr 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants