feat: support index based reading of OCI artifacts #1646
+653
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/feature
5 tasks
Refactored `ComponentVersionContainer` to allow fetching OCI manifests from top level OCI Image indexes. This is preparation for allowing the reference of native OCI Manifests that are themselves referenced via index first. This is prep work to allow native storage in OCI registries for local blobs that might themselves be stored previously as OCM Artifact Sets. They could now be accessed natively instead. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Added support to synthesize artifact blobs for nested OCI image manifests or indexes in cases where fewer references are provided. Updated error handling and blob synthesis logic accordingly. Signed-off-by: Jakob Möller <jakob.moeller@sap.com> Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
jakobmoellerdev
force-pushed
the
index-based-oci-artifacts
branch
from
738a236 to
7ce6b75
Compare
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
github-actions
bot
added
component/ocm-cli
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
jakobmoellerdev
force-pushed
the
index-based-oci-artifacts
branch
from
2e9d7c1 to
9f95f98
Compare
frewilhelm
reviewed
Dec 23, 2025
| // Build complete tag set from: | ||
| // - existing TAGS_ANNOTATION on any descriptor for this digest | ||
| // - incoming tags | ||
| tagSet := map[string]struct{}{} |
Contributor
There was a problem hiding this comment.
From what I can see this could also be just a []string. Am I missing something?
Comment on lines
+209
to
+212
| isOCI := a.base.FileSystemBlobAccess. | ||
| Access(). | ||
| GetInfo(). | ||
| GetDescriptorFileName() == OCIArtifactSetDescriptorFileName |
Contributor
There was a problem hiding this comment.
Just structure-wise - this variable could be set right before it is used on L256
| if template.Annotations == nil { | ||
| template.Annotations = map[string]string{} | ||
| } else { | ||
| template.Annotations = maps.Clone(template.Annotations) |
Contributor
There was a problem hiding this comment.
Cloning the map template.Annotations to template.Annotations looks odd. What is the reasoning?
Comment on lines
+46
to
+50
| if m.spec.MediaType == artdesc.MediaTypeImageIndex || m.spec.MediaType == artdesc.MediaTypeImageManifest { | ||
| // if we discover a localblob with an index or manifest media type, we can | ||
| // assume that we are dealing with a new style of artifact created by the new reference library. | ||
| m.mimeType = artifactset.MediaType(m.spec.MediaType) | ||
| } |
Contributor
There was a problem hiding this comment.
What if the localblob would be an actual OCI artifact? This would not make a difference as the new reference library creates its artifact in the OCI layout, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Refactored
ComponentVersionContainerto allow fetching OCI manifests from top level OCI Image indexes. This is preparation for allowing the reference of native OCI Manifests that are themselves referenced via index first. This is prep work to allow native storage in OCI registries for local blobs that might themselves be stored previously as OCM Artifact Sets. They could now be accessed natively instead.Which issue(s) this PR is related to
This allows native reading of OCM Artifacts created with the new v2 library that can use indexes to store artifacts natively
final stepping stone to prepare ADR for open-component-model/ocm-project#680
fixes open-component-model/ocm-project#717