BB-1551: Set sane defaults for Mongo Auth URL#109
Open
giovannicimolin wants to merge 1 commit intoopencraft-release/ironwood.2from
Open
BB-1551: Set sane defaults for Mongo Auth URL#109giovannicimolin wants to merge 1 commit intoopencraft-release/ironwood.2from
giovannicimolin wants to merge 1 commit intoopencraft-release/ironwood.2from
Conversation
xitij2000
approved these changes
Aug 13, 2019
Member
xitij2000
left a comment
There was a problem hiding this comment.
Looks good to go. I don't think the change to the edxapp role is necessary, but shouldn't hurt either, it's just reinforcing a default.
98159c8 to
02d4d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration Pull Request
Make sure that the following steps are done before merging
configuration-securerepo?