Skip to content

BB-1551: Set sane defaults for Mongo Auth URL#109

Open
giovannicimolin wants to merge 1 commit intoopencraft-release/ironwood.2from
giovanni/bb-1551-set-sane-defaults
Open

BB-1551: Set sane defaults for Mongo Auth URL#109
giovannicimolin wants to merge 1 commit intoopencraft-release/ironwood.2from
giovanni/bb-1551-set-sane-defaults

Conversation

@giovannicimolin
Copy link

Configuration Pull Request

Make sure that the following steps are done before merging

  • A devops team member has commented with 👍
  • are you adding any new default values that need to be overridden when this goes live?
    • Open a ticket (DEVOPS) to make sure that they have been added to secure vars.
    • Add an entry to the CHANGELOG.
  • Are you adding/updating any variables that need to be added/updated to a specific configuration-secure repo?

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. I don't think the change to the edxapp role is necessary, but shouldn't hurt either, it's just reinforcing a default.

@giovannicimolin giovannicimolin force-pushed the giovanni/bb-1551-set-sane-defaults branch from 98159c8 to 02d4d17 Compare August 14, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants