common: Fix GPUMemAddr and Block#18
Merged
MonsterDruide1 merged 4 commits intoopen-ead:masterfrom May 18, 2025
Merged
Conversation
Fuzzy2319
reviewed
May 16, 2025
Contributor
Fuzzy2319
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
include/common/aglGPUMemBlock.h line 55 at r3 (raw file):
class GPUMemBlockT : public GPUMemBlockBase { public: ~GPUMemBlockT() { ; }
Shouldn't this be marked as override?
MonsterDruide1
commented
May 17, 2025
Contributor
Author
MonsterDruide1
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Fuzzy2319 and @MonsterDruide1)
include/common/aglGPUMemBlock.h line 55 at r3 (raw file):
Previously, Fuzzy2319 wrote…
Shouldn't this be marked as
override?
Ah, good catch. Done.
Fuzzy2319
reviewed
May 17, 2025
Contributor
Fuzzy2319
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MonsterDruide1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for implementing
GpuMemAllocatorin SMO. Apparently, the arguments ofGPUMemBlockBasehave been wrong here - the function is invoked after thesead::Heap*-specificoperator newis called, but it does not take the heap itself, according to symbols in SMO. I could not find any reference to this in BotW.This causes no mismatches or compiler errors in BotW and SMO.
This change is