NintendoSDK: Update nn::os::Tick to struct#211
NintendoSDK: Update nn::os::Tick to struct#211MonsterDruide1 merged 3 commits intoopen-ead:masterfrom
nn::os::Tick to struct#211Conversation
68ffe02 to
c4c4fb8
Compare
|
Build checks obviously fail, because |
leoetlino
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
include/time/seadTickSpan.h line 18 at r1 (raw file):
s64 toS64() const { return mSpan; } u64 toTicks() const { return mSpan; }
hmm, why did we have both toS64 and toTicks in the first place...? maybe we should just remove toTicks
a3893e7 to
9ac3eed
Compare
|
I removed it in another commit - it requires two explicit casts, what do you think about it? |
|
idea: can we add a constructor to nn::os::Tick that takes a s64 (or u64, but I think s64 is more likely since we know that sead::TickSpan uses s64 all over the place)? |
|
Adding a |
|
makes sense - u64 sounds like the better idea to me then |
7ee8b6c to
08346f8
Compare
|
Updated accordingly. |
Required after merging open-ead/nnheaders#48
This change is