resource: Fix symbols in SharcArchiveRes for SMO#243
Merged
MonsterDruide1 merged 2 commits intoopen-ead:masterfrom Feb 17, 2026
Merged
resource: Fix symbols in SharcArchiveRes for SMO#243MonsterDruide1 merged 2 commits intoopen-ead:masterfrom
SharcArchiveRes for SMO#243MonsterDruide1 merged 2 commits intoopen-ead:masterfrom
Conversation
leoetlino
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like here is another versioning difference between SMO and BotW/Wonder: The existance of the function
isExistFileImpl_. It does not exist on SMO, while both BotW and Wonder make use of it, so this seems to lock down the order of sead versions in these games to be SMO < BotW < Wonder.Additionally, SMO's symbols show that most functions are not
consthere. I cannot verify whether they are const or not within later games, but I assume there was reason to make themconstfor those games, so I added another versioning flag for that.This change is