codec: Fix HashCRC16/32 for SMO#244
Merged
MonsterDruide1 merged 2 commits intoopen-ead:masterfrom Feb 24, 2026
Merged
Conversation
Contributor
|
You might as well change the with context one. https://decomp.me/scratch/2GwcF |
MonsterDruide1
force-pushed
the
smo-hashcrc
branch
from
5592989 to
e3cd6ed
Compare
Contributor
Author
|
Done - sort of. BotW disagrees with that change on |
german77
reviewed
Feb 17, 2026
Contributor
german77
left a comment
german77
left a comment
There was a problem hiding this comment.
@german77 reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).
MonsterDruide1
force-pushed
the
smo-hashcrc
branch
from
e3cd6ed to
c576daa
Compare
Contributor
Author
|
Rebased, please re-review. |
german77
reviewed
Feb 17, 2026
Contributor
german77
left a comment
german77
left a comment
There was a problem hiding this comment.
@german77 reviewed 3 files and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next up: The
HashCRCX::somethingWithContextdo not exist on SMO. Another version flag to remove those, and provide an implementation withoutContextinstead.3/4 functions are matching, the last one has a minor mismatch about duplicating a branch of instructions:
https://decomp.me/scratch/ITtEi
This change is