controller/nin: Fix NinJoyNpadDevice::NpadState#248
Merged
MonsterDruide1 merged 1 commit intoopen-ead:masterfrom Feb 25, 2026
Merged
controller/nin: Fix NinJoyNpadDevice::NpadState#248MonsterDruide1 merged 1 commit intoopen-ead:masterfrom
NinJoyNpadDevice::NpadState#248MonsterDruide1 merged 1 commit intoopen-ead:masterfrom
Conversation
MonsterDruide1
approved these changes
Feb 24, 2026
Contributor
MonsterDruide1
left a comment
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on german77).
MonsterDruide1
changed the title
NinJoyNpadDevice::NpadState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I been Working on controller input. This struct is currently wrong. The gaps in the struct actually correspond to the remaining states. We have 16 states in total and there are two sixAxis sensors, left and right.
Proof of work. https://decomp.me/scratch/5ucbW
This change is