Open
Conversation
german77
force-pushed
the
stringFormat
branch
2 times, most recently
from
3f1379c to
78aace5
Compare
german77
force-pushed
the
stringFormat
branch
from
78aace5 to
fd65f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the previous PR #237. This implements the string format side of yaml files.
This code has a couple of mismatches.
TextStreamFormat::readBit. This function parses the "0b110011" string by chopping off the "0b" part and parsing each char as 0 or 1. However I couldn't make the compiler follow the same flow. https://decomp.me/scratch/PKNGFTextStreamFormat::writeMemBlockThis function converts the data into a base64 string. I suspect the length calculation is not properly done.https://decomp.me/scratch/XzhbwTextStreamFormat::getNextData_This function actually reads the text file and selects the next field of data. The file supports multiple types of comments"",#and/* */. This has a lot of string related inlines in it, this made the logic very complex, I struggled getting even a meaningful level of match 0-40% after finally understanding the logic and several rewrites the match improved to 93% https://decomp.me/scratch/6wcQgThis change is