Conversation
|
here is the latest execution of All Tests: https://github.com/open-edge-platform/scenescape/actions/runs/21493175765 |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the CI test workflow to improve debugging and rerun capabilities by splitting functional and UI test groups into smaller, focused sub-groups. The changes remove the Basic Acceptance Tests (BATs) job and redistribute remaining tests into their respective categories, eliminating test execution duplication.
Changes:
- Split functional and UI tests into 6 sub-groups each (scenes, sensors, cameras, mqtt, objects, generic) with matrix strategy for parallel execution
- Added parameterizable test group selection via
FUNC_GROUPandUI_GROUPvariables - Enhanced artifact naming with unique identifiers per job/matrix combination to prevent conflicts
- Updated copyright years to 2026 across modified files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Makefile | Reorganizes test targets by splitting functional-tests and ui-tests into 6 sub-groups each, moves calibrate-camera-3d-ui-2d-ui to broken features |
| Makefile | Adds FUNC_GROUP and UI_GROUP variables for parameterized test execution |
| .github/workflows/tests-all.yml | Removes BATs job, converts functional and UI tests to matrix strategy with 6 sub-groups each, adds unique artifact naming |
| .github/actions/upload-artifacts/action.yaml | Parameterizes artifact naming and file paths with configurable inputs and retention policy |
.github/workflows/tests-all.yml
Outdated
| name: 'UI Tests (${{ fromJSON(''{"ui-scenes":"Scenes", | ||
| "ui-sensors":"Sensors","ui-cameras":"Cameras", | ||
| "ui-mqtt":"MQTT","ui-objects":"Objects", | ||
| "ui-generic":"Generic"}'')[matrix.group] }})' |
There was a problem hiding this comment.
This is a duplicate of the same JSON mapping pattern used in functional tests. The mapping between test groups and display labels should be defined once and reused to prevent inconsistencies if labels need to change.
|
Please clarify the logic here, why am I seeing only chosen reports and logs with some postfix "attemp", while all tests are running? I'd expect the same behavior as it is currently on main branch, where I can see the reports and logs from all test runs. Edit. Clarified offline. Looks like it's the same behavior as on main branch. |
This is the same as in main branch. e.g. https://github.com/open-edge-platform/scenescape/actions/runs/21483221999 |
|
Can we not add |
I removed attempt suffix from the log names in a previous commit |

📝 Description
Reworked how All Tests executes - split functional and ui test groups into sub-groups to help with debug and reruns.
Removed BATs, and put remaining tests into their respective groups, this gets rid of unnecessary duplication in executions for metric and unit test groups.
Link to a full execution for this branch: https://github.com/open-edge-platform/scenescape/actions/runs/21143582166
JIRA: ITEP-84743
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: