ci: Change to attest action and fix SBOM generator path#713
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the reliability and accuracy of the continuous integration pipeline by updating the attestation process. It transitions to a more current and consolidated GitHub Action for software bill of materials (SBOM) generation and attestation, alongside improving the precision of artifact path identification. These changes aim to streamline the workflow and bolster supply chain security practices. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 68 68
Lines 2951 2951
Branches 350 350
=======================================
Hits 2758 2758
Misses 135 135
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Actions workflow to use a newer attestation action and refines the artifact path for SBOM generation. While no security vulnerabilities were identified in the modified code, a critical issue was found with the action reference: the commit hash used for actions/attest is incorrect and belongs to a different, deprecated action, which will cause the CI workflow to fail. A specific suggestion has been provided to correct this.
This PR
This pull request updates the GitHub Actions workflow to use the latest attestation action and improves the accuracy of artifact attestation paths. The main changes focus on upgrading from deprecated actions to their newer consolidated versions and refining path specifications for attestation.
GitHub Actions upgrades:
actions/attest-sbomandactions/attest-build-provenanceto the unifiedactions/attest@v4.1.0action in both.github/actions/sbom-generator/action.ymland.github/workflows/release.yml, ensuring future compatibility and access to new features. [1] [2]Attestation path improvements:
subject-pathfor SBOM attestation to target the correct package directory: now usessrc/${{ inputs.project-name }}/**/${{ inputs.project-name }}.*.nupkginstead of a broad glob, reducing the risk of incorrect matches.actions/attestaction for attestation permissions, improving documentation and maintainability.Related Issues
Fixes #712