fix: flagsmith string to double conversion issue (#1557)

[kushbatra]

This PR

This PR fixes the issue where FlagsmithProvider.getDoubleDetails fails to parse flag values returned as strings (e.g., "42.42") from Flagsmith. Previously, the provider expected a java.lang.Double and returned an error if the value was a string. With this change, the provider will attempt to parse string values to Double when evaluating double flags, ensuring compatibility with Flagsmith environments that store numeric values as strings.

Related Issues

Fixes #1557

[gemini-code-assist]

Summary of Changes

Hello @kushbatra, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the FlagsmithProvider where it failed to correctly interpret numeric flag values when they were returned as strings from the Flagsmith service. By enhancing the "convertValue" method, the provider can now seamlessly convert string-based double values into their appropriate "Double" type, ensuring robust and compatible flag evaluation across different Flagsmith environments.

Highlights

• Improved Double Conversion: The FlagsmithProvider now correctly parses string representations of double values (e.g., "42.42") into "java.lang.Double" objects, resolving previous "TypeMismatchError" issues.
• Enhanced Type Handling: The "convertValue" method in "FlagsmithProvider.java" has been updated to include specific logic for "Double" type conversion, allowing for flexible handling of numeric flag values.
• New Test Coverage: A parameterized test "testConvertValue" has been added to "FlagsmithProviderTest.java" to validate the updated conversion logic, including cases for string-to-double parsing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses an issue where string values from Flagsmith were not being correctly converted to Double types. The changes in FlagsmithProvider.java are well-implemented, and the addition of parameterized tests for the convertValue method is a great practice to ensure the logic is sound. I've included a few suggestions to further enhance the code: one to correct a minor bug in an error message, and another to extend the conversion logic to also handle integers, which would improve the provider's robustness. A corresponding test case for the integer conversion is also suggested.

[kushbatra]

@ajhelsby @matthewelwell @chrfwow All the suggestions are handled, approve if all looks good.

[chrfwow]

Lgtm. But I wonder if we should also have a test that tests the error behaviour, i.e. when a String is passed on that does not convert to an int/double.
To make the DCO check green, you need to sign-off your commits and force push them @kushbatra

And you also need to run spotless:apply to fix the formatting issues