Issue1400 Ventilation template update #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r hour instead of a volumetric air change rate.
lucasverleyen
requested changes
Dec 20, 2024
Member
There was a problem hiding this comment.
Looks good, thanks for addressing the issue!
I don't have any remark on the changes you made. However, I have two suggestions for improvement.
- See comment on the constrainedby.
- The ConstantAirFlowRecup.mo model extends from the VentilationSystem.mo model. In that model, the parameter nZones is defined. However, that model extends from PartialSystem.mo, in which nZones is also defined. I suggest removing the parameter declaration of nZones in the VentilationSystem.mo, to avoid a duplicate parameter declaration. I have pushed these changes to this pull request.
lucasverleyen
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1400