-
Notifications
You must be signed in to change notification settings - Fork 64
Update user's guide #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user's guide #1445
Conversation
|
@jelgerjansen thanks a lot for the review! Concerning the references to the IDEAS development papers. |
@jelgerjansen I have double-checked the list of funding and contributors with Lieve. |
|
@lucasverleyen OK for me to restructure the References.mo file. |
|
@lucasverleyen I like the new structure of References.mo file. I also think it would make more sense to reference the relevant papers directly in the model documentation instead of having them in Main references |
|
@jelgerjansen @annadellisola I have restructured the References.mo file.
Can you do a new (final?) review? Btw, normally, I addressed all your comments/suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @lucasverleyen for all the effort! I gave some minor comments on the references.
Regarding the papers you did not find:
- ISO 13370: could be referenced in IDEAS.Buildings.Components.SlabOnGround, where it seems that UEqui is calculated according to the standard
- Defraye 2011: I was also not able to find a direct reference. IDEAS.Buildings.Components.OuterWall might use some correlations mentioned in the paper, but I did not manage to find the exact one
- Jurges 1924: no reference found
IDEAS/Buildings/Components/BaseClasses/RadiativeHeatTransfer/ZoneLwDistribution.mo
Outdated
Show resolved
Hide resolved
IDEAS/Buildings/Components/BaseClasses/ConvectiveHeatTransfer/InteriorConvection.mo
Outdated
Show resolved
Hide resolved
IDEAS/Buildings/Components/BaseClasses/RadiativeHeatTransfer/SwWindowResponse.mo
Show resolved
Hide resolved
@annadellisola thanks for your suggestions. I have added ISO 13370 as explained. I have removed Defraye and Jurges. |
|
@annadellisola @jelgerjansen thanks again for your useful input! I have addressed all comments. I think this PR is ready. |

Fixes #1444 and #1408