Issue1340 default wind speed #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
@jelgerjansen, indeed! unshielded = higher local wind speeds = higher wind pressures = higher ACH. |
lucasverleyen
requested changes
Jul 29, 2025
Member
There was a problem hiding this comment.
@jelgerjansen thanks for finalising this issue! I have done my review and added a few comments and suggestions. Most of them are inline comments, so those should be easy to resolve.
lucasverleyen
approved these changes
Aug 4, 2025
Member
lucasverleyen
left a comment
lucasverleyen
left a comment
There was a problem hiding this comment.
@jelgerjansen, looks great! I found three more textual details. But ready to merge afterwards!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1340 and #1447