Issue1381 embedded pipe #1457
Merged
Issue1381 embedded pipe #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
An additional improvement is adding a unit test to compare an embedded pipe system where the correction factor is/isn't used. |
lucasverleyen
requested changes
Aug 13, 2025
Member
lucasverleyen
left a comment
lucasverleyen
left a comment
There was a problem hiding this comment.
Thanks for the PR, @jelgerjansen! I have added a few comments. I have also added a few comments on the lines that were not modified, but might be improved in my opinion. I hope it is clear what I mean.
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
lucasverleyen
approved these changes
Aug 14, 2025
Member
lucasverleyen
left a comment
lucasverleyen
left a comment
There was a problem hiding this comment.
Looks great, thanks for taking care of my comments! I just made one more textual remark, but otherwise, ready to merge :-)
IDEAS/Fluid/HeatExchangers/RadiantSlab/BaseClasses/RadiantSlabChar.mo
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1381.