-
Notifications
You must be signed in to change notification settings - Fork 64
Issue1458 logo dark mode #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1458 logo dark mode #1460
Conversation
lucasverleyen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Jaap, for finding this issue and solving it. Much appreciated :-) I'll merge.
|
Cleanup and added figures in ppt for future reference |
jelgerjansen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted @Jaap-Neven, and thanks for fixing!
An additional improvement is changing the outer surface of the light bulb in dark mode. Can you update this?
|
@jelgerjansen @Jaap-Neven , if you update the light bulb, maybe you can change the house icon as well in the dark mode? |
|
@Jaap-Neven, thanks for taking care of our comments. Now, it looks perfect to me! |
|
Great! For me it does not show the cropping yet, but that can be a refreshing issue from my github. @lucasverleyen if you confirm both pictures look fine on the IDEAS homepage, then it can be merged. EDIT: Indeed it was my github, it now also looks good to me |
This is for #1458
Made new logo to support dark mode and implemented automatic switching between both.