Skip to content

Conversation

@Jaap-Neven
Copy link
Contributor

This is for #1458

Made new logo to support dark mode and implemented automatic switching between both.

Copy link
Member

@lucasverleyen lucasverleyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Jaap, for finding this issue and solving it. Much appreciated :-) I'll merge.

@lucasverleyen lucasverleyen linked an issue Aug 14, 2025 that may be closed by this pull request
@Jaap-Neven
Copy link
Contributor Author

Cleanup and added figures in ppt for future reference

Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @Jaap-Neven, and thanks for fixing!
An additional improvement is changing the outer surface of the light bulb in dark mode. Can you update this?

@lucasverleyen
Copy link
Member

@jelgerjansen @Jaap-Neven , if you update the light bulb, maybe you can change the house icon as well in the dark mode?

@lucasverleyen
Copy link
Member

@Jaap-Neven, thanks for taking care of our comments. Now, it looks perfect to me!

@Jaap-Neven
Copy link
Contributor Author

Jaap-Neven commented Aug 14, 2025

Great! For me it does not show the cropping yet, but that can be a refreshing issue from my github. @lucasverleyen if you confirm both pictures look fine on the IDEAS homepage, then it can be merged.

EDIT: Indeed it was my github, it now also looks good to me

@lucasverleyen lucasverleyen merged commit d28d024 into open-ideas:master Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logo contrast in Github dark mode

3 participants