feat: devcontainer, testing infrastructure, docs, DX improvements, and security policy#199
Open
akhilyad wants to merge 1 commit intoopen-jarvis:mainfrom
Open
feat: devcontainer, testing infrastructure, docs, DX improvements, and security policy#199akhilyad wants to merge 1 commit intoopen-jarvis:mainfrom
akhilyad wants to merge 1 commit intoopen-jarvis:mainfrom
Conversation
DevContainer & Docker - .devcontainer/Dockerfile.dev + devcontainer.json for one-click setup - docker-compose.dev.yml for full local dev environment Security - SECURITY.md: responsible disclosure policy and contact info Testing Infrastructure - tests/conftest.py: shared fixtures, tmp dirs, mock agent/config - tests/fixtures/.gitkeep: fixture directory scaffold - frontend/vitest.config.ts + tsconfig.test.json: Vitest setup - frontend/src/App.test.tsx: initial frontend smoke test - frontend/src/test/setup.ts: jsdom + testing-library config - frontend/package.json: adds vitest, @testing-library/* dev deps Documentation - docs/tutorials/custom-scorer.md: 200-line scorer tutorial - docs/tutorials/index.md: tutorials landing page Code Quality - src/openjarvis/exceptions.py: structured exception hierarchy - src/openjarvis/__lazy__.py: lazy module import utilities - src/openjarvis/__init__.py: wire lazy imports + new submodules - src/openjarvis/cli/debug_cmd.py: jarvis dev debug command - src/openjarvis/server/routes.py: realtime metrics endpoint - frontend/src/components/Chat/InputArea.tsx: a11y improvements - .gitignore: comprehensive entries for Python/Node/Rust/editors Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
let me know, thanks |
Author
|
Hi maintainers! 👋 Could someone please approve the workflow runs so CI can execute on this PR? GitHub is holding them pending approval since this is from an external fork. The workflows waiting for approval are:
Thanks for taking the time to review! |
Collaborator
|
Hey @akhilyad, same feedback as #198. This PR covers devcontainer setup, testing infrastructure, docs, DX improvements, and a security policy all in one. Could you split it into focused PRs? For example:
Smaller PRs are much easier to review and merge quickly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Developer experience, testing, documentation, and security improvements.
DevContainer & Docker
.devcontainer/Dockerfile.dev+devcontainer.json: one-click VS Code dev environmentdocker-compose.dev.yml: full local dev stack with hot reloadSecurity
SECURITY.md: responsible disclosure policy and contact infoTesting Infrastructure
tests/conftest.py: shared pytest fixtures (tmp dirs, mock agent, mock config)tests/fixtures/.gitkeep: fixture directory scaffoldfrontend/vitest.config.ts+tsconfig.test.json: Vitest test setupfrontend/src/App.test.tsx: frontend smoke testfrontend/src/test/setup.ts: jsdom + @testing-library configfrontend/package.json: adds vitest and @testing-library dev depsDocumentation
docs/tutorials/custom-scorer.md: 200-line tutorial on building custom eval scorersdocs/tutorials/index.md: tutorials landing pageCode Quality & DX
src/openjarvis/exceptions.py: structured exception hierarchy (400+ lines)src/openjarvis/__lazy__.py: lazy module import utilities for faster startupsrc/openjarvis/__init__.py: wires lazy imports and new submodulessrc/openjarvis/cli/debug_cmd.py:jarvis devdebug commandsrc/openjarvis/server/routes.py: realtime metrics endpoint for dashboardfrontend/src/components/Chat/InputArea.tsx: accessibility improvements.gitignore: comprehensive entries for Python/Node/Rust/editor artifactsTest plan
uv run pytest tests/ -v --tb=short -m "not live and not cloud"passes with new fixturescd frontend && npm testruns Vitest suitejarvis devdebug command worksuv run ruff check src/ tests/passesGenerated with Claude Code