Open
Conversation
… memory and system prompt settings
Collaborator
|
Hey @krypticmouse, the Synapse integration looks well-structured. The Rust backend and Python wrapper follow the existing patterns nicely. Before we can merge, a couple things:
Happy to review again once updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This addition allows for more flexible memory management and integration with Synapse services.
How was this tested?
rust/crates/openjarvis-tools/src/storage/synapse.rscoveringSynapseMemory::parse_results():test_parse_results_empty- verifies an empty JSON object returns an empty result vectest_parse_results_array- verifies a JSON array of objects is correctly parsed intoRetrievalResultstructstest_parse_results_object_with_data- verifies a JSON object with a nested "data" array is unwrapped and parsed correctlycargo test -p openjarvis-tools --lib storage::synapse)synapse serve); the client methods (emit, query, health, ping, etc.) are thin HTTP wrappers over synapse-client which is itself tested upstreamcargo checkpasses across the full workspace with no errorsChecklist
uv run pytest tests/ -v)uv run ruff check src/ tests/)uv run ruff format --check src/ tests/)