Skip to content

Revert "[UV] update torch version" #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayank31398 merged 1 commit into from
Apr 17, 2026
Merged

Revert "[UV] update torch version" #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Repository = "https://github.com/open-lm-engine/lm-engine"

[project.optional-dependencies]
cuda = [
"torch>=2.11.0",
"torch>=2.10.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constraint torch>=2.10.0 still allows the installation of version 2.11.0 if it is available in the package registry. If the intent of this revert is to avoid issues introduced in version 2.11.0, this change may be ineffective as the package manager will still resolve to the highest compatible version. Consider using an exact pin or a version range (e.g., torch>=2.10.0,<2.11.0) to ensure the problematic version is not installed.

]
dev = [
"pre-commit>=4.4.0",
Expand All @@ -41,12 +41,12 @@ mamba2 = [
"mamba-ssm>=2.2.6.post3",
]
tpu = [
"torch>=2.11.0",
"torch==2.10.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a version mismatch between torch==2.10.0 and torch-xla==2.9.0 (on line 45). PyTorch XLA requires the major and minor versions of torch and torch-xla to match for binary compatibility and stability on TPU. Additionally, this extra uses an exact pin (==) while the cuda and data extras use >=, which is inconsistent. To ensure a stable TPU environment, it is recommended to align the torch version with the pinned torch-xla version.

Suggested change
"torch==2.10.0",
"torch==2.9.0",

"torch-xla[pallas,tpu]==2.9.0",
]
data = [
"ray[default]>=2.52.1",
"torch>=2.11.0",
"torch>=2.10.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the cuda extra, the constraint torch>=2.10.0 here still permits version 2.11.0 to be resolved. If the goal of this revert is to avoid 2.11.0, consider using a more restrictive constraint or an exact pin.

"zstandard>=0.25.0",
"aiobotocore>=3.0.0",
]
Expand Down
Loading