Skip to content

Conversation

@opitz
Copy link

@opitz opitz commented Nov 24, 2023

removed outdated legacy methods.
updated externallib.php
fixed optional parameter before mandatory parameter
updated tests

@gthomas2
Copy link

gthomas2 commented Dec 7, 2023

Hi

I filed a 4.2 PR just before yours. Maybe it's worthwhile collaborating on this or maybe you'd like to check the differences to see if anything got missed in either PR?

@opitz
Copy link
Author

opitz commented Dec 8, 2023

@gthomas2 yes,please!
How do we do that best?

@gthomas2
Copy link

@opitz - So sorry for the super late reply on this. I'll send you an email from my company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants