Skip to content

ucx: meet at the pmix fence before disconnecting to avoid an infinite loop #13519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ucx: meet at the pmix fence before disconnecting to avoid an infinite loop #13519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions opal/mca/common/ucx/common_ucx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,15 @@ OPAL_DECLSPEC int opal_common_ucx_del_procs(opal_common_ucx_del_proc_t *procs, s
size_t my_rank, size_t max_disconnect,
ucp_worker_h worker)
{
opal_common_ucx_del_procs_nofence(procs, count, my_rank, max_disconnect, worker);
/* fence while we are still connected to our peers */
int rc = opal_common_ucx_mca_pmix_fence(worker);
if (OPAL_SUCCESS != rc) {
MCA_COMMON_UCX_ERROR("pmix fence failed during ucx proc disconnection: %d", rc);
return rc;
}

return opal_common_ucx_mca_pmix_fence(worker);
/* now that everyone is at the barrier, they are free to go their separate ways */
return opal_common_ucx_del_procs_nofence(procs, count, my_rank, max_disconnect, worker);
}

static void safety_valve(void) __opal_attribute_destructor__;
Expand Down