Skip to content

Comments

Fix/1073#1074

Open
aaronchongth wants to merge 11 commits intomainfrom
fix/1073
Open

Fix/1073#1074
aaronchongth wants to merge 11 commits intomainfrom
fix/1073

Conversation

@aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Feb 20, 2026

What's new

Fixes #1073

  • use generated pydantic model for BeaconState
  • fix stale use of id_

How to test

The Beacons microapp have been deprecated and removed, so we don't have a full code path to test the UI anymore.
Test with commit 5f0051b, which is just the fix with extra lines of DB access similar to how the routes work.

Publish a beacon state using ROS 2 after sourcing the workspace,

ros2 topic pub --once /beacon_state rmf_fleet_msgs/msg/BeaconState "{id: test_beacon, online: true, category: visual, activated: true, level: L1}"

Self-checks

  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Copy link
Member Author

CI to pass, waiting for #1077

@aaronchongth aaronchongth moved this from Inbox to In Review in PMC Board Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in /beacons endpoints: BeaconState.model_validate(TortoiseModel) raises 500 when DB has rows

1 participant