-
Notifications
You must be signed in to change notification settings - Fork 67
fix reporting and reporting server #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2fe7c33
85824b1
274ee18
39a5676
971b2f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,6 +80,23 @@ spec: | |
| ports: | ||
| - protocol: TCP | ||
| port: 8000 | ||
|
|
||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: rmf-server-ws | ||
| labels: | ||
| app: rmf-server-ws | ||
| tier: app | ||
| spec: | ||
| selector: | ||
| app: rmf-server | ||
| tier: app | ||
| ports: | ||
| - protocol: TCP | ||
| port: 8001 | ||
|
|
||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
|
|
@@ -107,6 +124,8 @@ spec: | |
| env: | ||
| - name: RMF_API_SERVER_CONFIG | ||
| value: /rmf-server-config/rmf_server_config.py | ||
| - name: RMW_IMPLEMENTATION | ||
| value: rmw_fastrtps_cpp | ||
|
Comment on lines
+127
to
+128
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I recalled that this was added to workaround minikube misconfiguration, iirc the problem was because minikube isolates the networks so other dds wouldn't work if rmf is ran locally and api-server is ran on the cluster. It only works for fastrtps because it supports shared memory. I think we should remove this as abusing shared memory features to workaround broken network configuration is wrong. iirc it is not possible to create a configuration that works for other dds without also putting rmf inside the cluster, and even if it is in the cluster, it might still not work because dds requires udp broadcast which might not be supported by minikube. We can also consider writing some deployment instructions for rmf + kubernetes in the rmf meta repo and link to that here since deploying rmf is out of scope of this repo. It might also make sense to move this example deployment to the meta repo as deployment of rmf + rmf-web has become quite coupled together, making it hard to have separate docs without explaining the other. |
||
| volumeMounts: | ||
| - mountPath: /rmf-server-config | ||
| name: rmf-server-config | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
|
|
||
| config = deepcopy(default_config) | ||
| config["host"] = "0.0.0.0" | ||
| config["port"] = 8000 | ||
| config["base_port"] = 8000 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New api-server reverts to using |
||
| config["db_url"] = "postgres://rmf-server:rmf-server@rmf-server-db/rmf-server" | ||
| config["public_url"] = "https://example.com/rmf/api/v1" | ||
| config["log_level"] = "INFO" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,9 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| kubectl() { | ||
| .bin/minikube kubectl -- "$@" | ||
| } | ||
| export -f kubectl | ||
|
|
||
| kubectl kustomize "$1" | envsubst |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,14 @@ import React from 'react'; | |
| import ReactDOM from 'react-dom'; | ||
| import App from './components/app'; | ||
| import * as serviceWorker from './serviceWorker'; | ||
| import LocalizationProvider from '@mui/lab/LocalizationProvider'; | ||
| import AdapterDateFns from '@mui/lab/AdapterDateFns'; | ||
|
Comment on lines
+5
to
+6
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| ReactDOM.render( | ||
| <React.StrictMode> | ||
| <App /> | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <App /> | ||
| </LocalizationProvider> | ||
| </React.StrictMode>, | ||
| document.getElementById('root'), | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed anymore as the api-server no longer uses multiple ports.