Skip to content

draft: remove reporting#589

Closed
koonpeng wants to merge 2 commits intomainfrom
remove-reporting
Closed

draft: remove reporting#589
koonpeng wants to merge 2 commits intomainfrom
remove-reporting

Conversation

@koonpeng
Copy link
Copy Markdown
Collaborator

@koonpeng koonpeng commented Mar 1, 2022

What's new

Testing how it would look like if we were to remove reporting from this repo. The diffs here can be used as reference to migrate reporting to its own repo.

This also fixes react-components lint errors.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@koonpeng koonpeng marked this pull request as draft March 1, 2022 06:09
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2022

Codecov Report

Merging #589 (16185d8) into main (300a534) will decrease coverage by 1.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   75.70%   73.83%   -1.88%     
==========================================
  Files         312      233      -79     
  Lines        6017     4815    -1202     
  Branches      642      556      -86     
==========================================
- Hits         4555     3555    -1000     
+ Misses       1272     1105     -167     
+ Partials      190      155      -35     
Flag Coverage Δ
dashboard 62.30% <ø> (ø)
react-components 69.27% <ø> (-8.16%) ⬇️
reporting ?
reporting-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/react-components/lib/robots/utils.ts 9.09% <0.00%> (-90.91%) ⬇️
...ackages/react-components/lib/tasks/create-task.tsx 1.37% <0.00%> (-76.73%) ⬇️
packages/react-components/lib/simple-info.tsx 7.89% <0.00%> (-52.64%) ⬇️
...kages/react-components/lib/tasks/task-timeline.tsx 56.66% <0.00%> (-43.34%) ⬇️
packages/react-components/lib/tasks/task-table.tsx 53.84% <0.00%> (-21.16%) ⬇️
packages/react-components/lib/form-inputs.tsx 75.00% <0.00%> (-16.67%) ⬇️
...ckages/react-components/lib/map/robots-overlay.tsx 66.66% <0.00%> (-9.53%) ⬇️
packages/react-components/lib/utils/misc.ts 92.30% <0.00%> (-7.70%) ⬇️
...kages/react-components/lib/confirmation-dialog.tsx 83.33% <0.00%> (-5.56%) ⬇️
...-components/lib/commands/delivery-request-form.tsx 80.90% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300a534...16185d8. Read the comment docs.

@koonpeng koonpeng requested a review from aaronchongth March 1, 2022 06:18
@mayman99
Copy link
Copy Markdown
Contributor

mayman99 commented Mar 2, 2022

This also fixes react-components lint errors.

I propose we separate this from this PR.

Testing how it would look like if we were to remove reporting from this repo. The diffs here can be used as reference to migrate reporting to its own repo.

I also propose we hold this off until #588 and #585 get merged, as they both change the reporting side.

@aaronchongth
Copy link
Copy Markdown
Member

Per VC, we should decouple fixing the linting errors from this PR, i.e. have #587 merged first too

@aaronchongth
Copy link
Copy Markdown
Member

Closing via #628

@aaronchongth aaronchongth deleted the remove-reporting branch July 4, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants