Conversation
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: Pranay Shirodkar <39498451+PranayShirodkar@users.noreply.github.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Closed
Signed-off-by: ahcorde <ahcorde@gmail.com>
…stener Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Collaborator
Author
|
@Yadunund as you are the original reviewer, if don't mind to take another look. I think I address all your comments |
Yadunund
approved these changes
Nov 14, 2022
Member
Yadunund
left a comment
Yadunund
left a comment
There was a problem hiding this comment.
Thanks for making all the changes! Happy to merge this in!
@PranayShirodkar will be delighted to see this.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with this PR #1
Open a new PR to address the feedback and follow up the package
rmf_human_detector
ROS 2 node that subscribes to
sensor_msgs::Imagemessages published by a monocular camera and publishes the detections over/rmf_obstaclesasrmf_obstacle_msgs::Obstaclesmessage. The node runsYOLOv5to detect the presence of humans as obstacles.Launch human detector
First launch rmf demos hotel world with a camera in it from open-rmf/rmf_demos#154. Then: