Conversation
|
First time contributing to RMF. Should I do what is suggested here, or keep it in mind for the next time? |
|
@enfff could you ensure DCO passes? |
|
Absolutely, I'll do it asap |
Signed-off-by: Enfff <enforcetitan@gmail.com>
Signed-off-by: Enfff <enforcetitan@gmail.com>
…/rmf/blob/main/docs/Development-and-Release.md) Signed-off-by: Enfff <enforcetitan@gmail.com>
| _latest_scan->angle_min, _latest_scan->angle_max, _latest_scan->angle_increment, | ||
| _latest_scan->angle_min, _latest_scan->angle_max, | ||
| _latest_scan->angle_increment, |
There was a problem hiding this comment.
Nit: Undo unnecessary formatting change.
There was a problem hiding this comment.
The last thing I did after writing the code was formatting the text as specified in
Code Style and C++ conventions, in fact that line is long 84 characters (counting spaces). Do you still prefer it the way it was written before?
There was a problem hiding this comment.
Hello, any update on this?
Signed-off-by: Enfff <enforcetitan@gmail.com>
…printed use_sim_time parameter for debugging reasons Signed-off-by: Enfff <enforcetitan@gmail.com>
mxgrey
left a comment
There was a problem hiding this comment.
Thanks for the contribution and sorry for how long it took to follow up. This repo is on the fringe of where we usually focus our effort, so it went overlooked. From now on PRs opened for this repo will be automatically added to the project board.
Bug fix
Fixed bug
The node
laserscan_detectorkept generating such messages:Message Filter dropping message: frame '' at time 0.000 for reason 'the frame id of the message is emptyThe node
lane_blocker_nodewas not publishing the lane closure requests correctlyFix applied
header.frame_idwith_latest_scan->header.frame_idas suggested by @Yadunund in issue #9Furthermore, I changed the obstacle transform time to
rclcpp::Time(obstacle.header.stamp)as that's the most accurate timestamp, instead oftf2::TimePointZerowhich is the last availableGenAI Use
We follow OSRA's policy on GenAI tools
I used Copilot v1.35.0 and Claude Sonnet 4 to generate the parameter table in the README