Skip to content

Fix/laneblocker#37

Merged
mxgrey merged 5 commits intoopen-rmf:mainfrom
enfff:fix/laneblocker
Oct 8, 2025
Merged

Fix/laneblocker#37
mxgrey merged 5 commits intoopen-rmf:mainfrom
enfff:fix/laneblocker

Conversation

@enfff
Copy link
Copy Markdown
Contributor

@enfff enfff commented Jul 11, 2025

Bug fix

Fixed bug

  • The node laserscan_detector kept generating such messages:
    Message Filter dropping message: frame '' at time 0.000 for reason 'the frame id of the message is empty

  • The node lane_blocker_node was not publishing the lane closure requests correctly

Fix applied

  • I filled the message header.frame_id with _latest_scan->header.frame_id as suggested by @Yadunund in issue #9
  • I rewrote the logic for associating obstacles to the lanes

Furthermore, I changed the obstacle transform time to rclcpp::Time(obstacle.header.stamp) as that's the most accurate timestamp, instead of tf2::TimePointZero which is the last available

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

I used Copilot v1.35.0 and Claude Sonnet 4 to generate the parameter table in the README

@enfff
Copy link
Copy Markdown
Contributor Author

enfff commented Jul 11, 2025

First time contributing to RMF. Should I do what is suggested here, or keep it in mind for the next time?

@Yadunund
Copy link
Copy Markdown
Member

@enfff could you ensure DCO passes?

@enfff
Copy link
Copy Markdown
Contributor Author

enfff commented Jul 12, 2025

Absolutely, I'll do it asap

@enfff enfff force-pushed the fix/laneblocker branch from 511c3a8 to 0760532 Compare July 13, 2025 15:03
Comment on lines -303 to +304
_latest_scan->angle_min, _latest_scan->angle_max, _latest_scan->angle_increment,
_latest_scan->angle_min, _latest_scan->angle_max,
_latest_scan->angle_increment,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Undo unnecessary formatting change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last thing I did after writing the code was formatting the text as specified in
Code Style and C++ conventions, in fact that line is long 84 characters (counting spaces). Do you still prefer it the way it was written before?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, any update on this?

@enfff enfff requested a review from Yadunund July 17, 2025 16:31
enfff added 2 commits August 22, 2025 18:19
…printed use_sim_time parameter for debugging reasons

Signed-off-by: Enfff <enforcetitan@gmail.com>
Copy link
Copy Markdown

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for how long it took to follow up. This repo is on the fringe of where we usually focus our effort, so it went overlooked. From now on PRs opened for this repo will be automatically added to the project board.

@mxgrey mxgrey merged commit 072037f into open-rmf:main Oct 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants